Skip to content

Update FSDP tutorial #2116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 15, 2022
Merged

Update FSDP tutorial #2116

merged 5 commits into from
Nov 15, 2022

Conversation

davidberard98
Copy link
Contributor

@davidberard98 davidberard98 commented Nov 12, 2022 •
edited
Loading

  • rename default_auto_wrap_policy -> size_based_auto_wrap_policy (the interface was changed)
  • indentation/imports/etc

@davidberard98
Update FSDP tutorial
51f640e 
* rename default_auto_wrap_policy -> size_based_auto_wrap_policy
* import functools
* indentation
@davidberard98
Copy link
Contributor Author

re: size_based_auto_wrap_policy - note that older versions (before pytorch/pytorch#76858) would still need default_auto_wrap_policy; do we need to mention this?

@netlify
Copy link

netlify bot commented Nov 12, 2022 •
edited
Loading

✅ Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 14afc05
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/63728110604418000812d04f
😎 Deploy Preview https://deploy-preview-2116--pytorch-tutorials-preview.netlify.app/intermediate/fsdp_tutorial
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

zhaojuanmao
zhaojuanmao approved these changes Nov 12, 2022
View reviewed changes
Copy link

@zhaojuanmao zhaojuanmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it

@svekars
Copy link
Contributor

svekars commented Nov 14, 2022

re: size_based_auto_wrap_policy - note that older versions (before pytorch/pytorch#76858) would still need default_auto_wrap_policy; do we need to mention this?

Since we don't version the tutorials build, I think it's a good idea to mention that and show how.

svekars
svekars reviewed Nov 14, 2022
View reviewed changes
@davidberard98
Use Svetlana's suggestion on wording for the note on size_based_auto_…
14afc05 
…wrap_policy

Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
@davidberard98 davidberard98 merged commit 0ab50ad into master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svekars svekars svekars approved these changes

@zhaojuanmao zhaojuanmao zhaojuanmao approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@HamidShojanazeri HamidShojanazeri Awaiting requested review from HamidShojanazeri

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidberard98 @svekars @zhaojuanmao @facebook-github-bot